gaoran10 commented on code in PR #15157:
URL: https://github.com/apache/pulsar/pull/15157#discussion_r905702464
##########
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java:
##########
@@ -219,44 +222,50 @@ public CompletableFuture<TxnMeta> getTxnMeta(TxnID txnID)
{
@Override
public CompletableFuture<TxnID> newTransaction(long timeOut) {
- CompletableFuture<TxnID> completableFuture = new CompletableFuture<>();
- internalPinnedExecutor.execute(() -> {
- if (!checkIfReady()) {
- completableFuture.completeExceptionally(new
CoordinatorException
- .TransactionMetadataStoreStateException(tcID,
State.Ready, getState(), "new Transaction"));
- return;
- }
+ if (this.maxActiveTransactionsPerCoordinator == 0
+ || this.maxActiveTransactionsPerCoordinator >
txnMetaMap.size()) {
Review Comment:
Does this check `this.maxActiveTransactionsPerCoordinator >
txnMetaMap.size()` has race condition problem?
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2592,6 +2592,12 @@ public class ServiceConfiguration implements
PulsarConfiguration {
)
private long transactionBufferClientOperationTimeoutInMills = 3000L;
+ @FieldContext(
+ category = CATEGORY_TRANSACTION,
+ doc = "The max active transactions per transaction coordinator."
Review Comment:
```suggestion
doc = "The max active transactions per transaction coordinator,
default value 0 indicate no limit."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
