codelipenghui commented on a change in pull request #3962: Feature /
Interceptor for negative ack redelivery
URL: https://github.com/apache/pulsar/pull/3962#discussion_r276524062
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerInterceptors.java
##########
@@ -109,9 +110,29 @@ public void onAcknowledge(Consumer<T> consumer, MessageId
messageId, Throwable e
* @param exception exception returned by broker.
*/
public void onAcknowledgeCumulative(Consumer<T> consumer, MessageId
messageId, Throwable exception) {
- for (int i = 0; i < interceptors.size(); i++) {
+ for (ConsumerInterceptor<T> interceptor : interceptors) {
try {
- interceptors.get(i).onAcknowledgeCumulative(consumer,
messageId, exception);
+ interceptor.onAcknowledgeCumulative(consumer, messageId,
exception);
+ } catch (Exception e) {
+ log.warn("Error executing interceptor onAcknowledgeCumulative
callback ", e);
+ }
+ }
+ }
+
+ /**
+ * This method will be called when a redelivery from a negative
acknowledge occurs.
+ * <p>
+ * This method calls {@link
ConsumerInterceptor#onNegativeAckRedelivery(Consumer, Set<MessageId>)} method
for each interceptor.
+ * <p>
+ * This method does not throw exceptions. Exceptions thrown by any of
interceptors in the chain are logged, but not propagated.
+ *
+ * @param consumer the consumer which contains the interceptors
+ * @param messageIds set of messages ids being redelivery.
+ */
+ public void onNegativeAckRedelivery(Consumer<T> consumer, Set<MessageId>
messageIds) {
Review comment:
> when consumer.negativeAcknowledgement() will occur almost at that very
moment (consumer.negativeAcknowledgement() just adds the msg to
negativeAckTracker) and the user could solve this by himself, instead, with
adding onNegativeAckRedelivery() offers a feature which the user cannot solve
right now.
@lovelle this express the real behavior for the interceptor.
> Regarding the naming of this method, I think it might get a bit misleading
because the redelivery might actually get to a different consumer. Eg.
ConsumerA calls Nack() and after 1 min ConsumerB will get the message again.
@merlimat Agree with what you are worried about, If named
`onNegativeAckRedelivery`, it is more like messages is redelivery to this
consumer by another consumer call `onNegativeAck()`.
So, how about `onNegativeAckSend`. For this PR, this is more able to express
the true interception behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
