nicoloboschi opened a new pull request, #16251:
URL: https://github.com/apache/pulsar/pull/16251

   
   Master Issue: #16250 
   
   ### Modifications
   
   * Introduced new command `bin/pulsar-shell`
     * Implemented all the basic shell features (autocompletion, persisted 
history, welcome, quit, ctrl+c trap)
     * Implemented wrappers for `pulsar-admin` and `pulsar-client`
   * Added JLine3 to the classpath. 
   * Refactored `pulsar-client` to use `pulsar-admin-commons.sh` since they 
file content are nearly equal. Now also the new script use that
   
   
   Notes:
   1. JCommander uses space as option value separator (e.g. `--admin-url 
http://myhost`). JLine only supports options with `=`. In order to make the 
completion works when using option, the last one is now accepted by the shell. 
The first one will works correctly but the completion won't work after that 
option.
   2. ZK Cli uses JLine2 - (still need to verify classpath clashes and 
compatibility)
   
   Missing implementations: (will follow up later)
   - non-interactive mode
   - other CLI commands
   
   ### Verifying this change
   
   This change added tests and can be verified as follows:
   
   - Build the branch
   - Run ´bin/pulsar-shell´ and try admin and client commands, check history, 
check autocompletion
   
   ### Documentation
   
   - [x] `doc-required` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to