poorbarcode commented on code in PR #16165:
URL: https://github.com/apache/pulsar/pull/16165#discussion_r908034600


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java:
##########
@@ -1188,4 +1201,164 @@ private void checkRequestTimeout() {
     }
 
     private static final Logger log = LoggerFactory.getLogger(ClientCnx.class);
+
+    /**
+     * Check if the client connection is eligible for being marked as idle. 
+     *  if so, {@link org.apache.pulsar.client.impl.ClientCnx#tryMarkIdle()} 
will be invoked next.
+     * @return if the connection is idle.
+     */

Review Comment:
   > *  @return true if the connection is eligible 
   
   Hi @gaozhangmin 
   This line ends with `space`, style check will fail.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to