lovelle commented on a change in pull request #4062: Delayed message delivery 
implementation
URL: https://github.com/apache/pulsar/pull/4062#discussion_r276697926
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
 ##########
 @@ -302,6 +301,21 @@ public static int getBatchSizeforEntry(ByteBuf 
metadataAndPayload, Subscription
         return -1;
     }
 
+    public static MessageMetadata peekMessageMetadata(ByteBuf 
metadataAndPayload, Subscription subscription,
 
 Review comment:
   Just a small hint, maybe we could refactor ` getBatchSizeforEntry()` in 
order to use this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to