Nicklee007 opened a new pull request, #16273:
URL: https://github.com/apache/pulsar/pull/16273

   Fixes #16272
   
   ### Motivation
   Fix the local police IsolationGroups permanent cover the 
`defaultIsolationGroups`, which will cause even we rollback the local police to 
empty,  the `defaultIsolationGroups` always use the latest local police 
IsolationGroups setting and  is not use the setting in broker.conf as default.
   
   The `defaultIsolationGroups` be covered point.
   
https://github.com/apache/pulsar/blob/0eed84203b23e325ac15d7dc50e1ed6dbdf4fa2a/pulsar-broker-common/src/main/java/org/apache/pulsar/bookie/rackawareness/IsolatedBookieEnsemblePlacementPolicy.java#L141
   
   ### Modifications
   1.  fix the `defaultIsolationGroups` be covered point 
   2. merge the `newEnsemble` and `replaceBookie` method duplication code to 
`getBlacklistedBookies()` ,to avoid change only cover one method in the future. 
   3. add some unit test.
   `
   ### Verifying this change
   
   - [X] `doc-not-needed` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to