BewareMyPower commented on code in PR #15634:
URL: https://github.com/apache/pulsar/pull/15634#discussion_r909554405
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/NettyClientSslContextRefresher.java:
##########
@@ -46,6 +46,8 @@ public class NettyClientSslContextRefresher extends
SslContextAutoRefreshBuilder
public NettyClientSslContextRefresher(SslProvider sslProvider, boolean
allowInsecure,
String trustCertsFilePath,
+ String certsFilePath,
+ String keyFilePath,
Review Comment:
But it looks like the built-in client or admin doesn't pass any non-null
arguments to these two arguments as well. Why do they need this two extra
parameters? I mean, all references pass `null` arguments, they are meaningless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
