tisonkun opened a new pull request, #16320:
URL: https://github.com/apache/pulsar/pull/16320

   ### Motivation
   
   see also https://lists.apache.org/thread/65skwo492w2nfjwhb3d9y51roq13h8bs
   
   PulsarAdminImpl has a static block requires classpath contains exact either 
of:
   
   * slf4j-jdk14
   * jul-to-slf4j
   
   It causes an issue that if user depends on neither slf4j-jdk14 nor 
jul-to-slf4j, PulsarAdminImpl will panic with NoClassDefFoundError. And thus, 
user should add one of them (basically jul-to-slf4j) even if they don't depend 
on it effectively.
   
   ### Modifications
   
   Remove jul-to-slf4j from all modules under Pulsar.
   
   The Pulsar project uses slf4j as the logging facade consistently. If a user 
want to add a dependency using a different logging framework, they should take 
care of the packaging strategy themselves.
   
   pulsar-sql will add a dependency to slf4j-jdk14 which redirect slf4j to jul. 
Since this is a unidirectional redirection, it won't cause runtime error, but 
pulsar-sql will logging with jul framework, which is the same as with previous 
workaround.
   
   cc @merlimat as the original author of this stuff.
   cc @syhily who points me out this issue.
   cc @codelipenghui @eolivelli 
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is already covered by existing tests.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes)
   
   The motivation and affected scope are described above.
   
   ### Documentation
   
   - [x] `doc-not-needed` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to