sijie commented on a change in pull request #4079: PIP-34 Key_Shared
subscription core implementation.
URL: https://github.com/apache/pulsar/pull/4079#discussion_r276890830
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/TypedMessageBuilderImpl.java
##########
@@ -68,6 +68,12 @@ public MessageId send() throws PulsarClientException {
return this;
}
+ @Override
+ public TypedMessageBuilder<T> orderingKey(String orderingKey) {
Review comment:
I would prefer using `byte[]` for ordering key. because you have to handle
charsets and encoding for `String`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
