HQebupt opened a new pull request, #16343:
URL: https://github.com/apache/pulsar/pull/16343
Cherry-pick #16219
### Motivation
It failed to expose bookkeeper client managed ledger stats to prometheus if
setting `bookkeeperClientExposeStatsToPrometheus=true` in
`ServiceConfiguration`. Because creating BkClient ignore the `StatsLogger` and
use the `NullStatsLogger.INSTANCE` as default.
```java
//class: org.apache.pulsar.broker.BookKeeperClientFactoryImpl
@Override
public BookKeeper create(ServiceConfiguration conf, ZooKeeper zkClient,
EventLoopGroup eventLoopGroup,
Optional<Class<? extends
EnsemblePlacementPolicy>> ensemblePlacementPolicyClass,
Map<String, Object> properties) throws
IOException {
return create(conf, zkClient, eventLoopGroup,
ensemblePlacementPolicyClass, properties,
NullStatsLogger.INSTANCE);
}
```
### Modifications
Add `StatsLogger` into BookKeeperClientFactory when creating BkClient.
The screenshot below is the result of my verification.
<img width="1698" alt="image"
src="https://user-images.githubusercontent.com/4970972/175766594-3b362710-137f-4ae2-94ec-d8cea8319b8b.png";>
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
If `yes` was chosen, please highlight the changes
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/4970972/175766594-3b362710-137f-4ae2-94ec-d8cea8319b8b.png"](https://user-images.githubusercontent.com/4970972/175766594-3b362710-137f-4ae2-94ec-d8cea8319b8b.png"){kind=link}