merlimat opened a new pull request, #16345:
URL: https://github.com/apache/pulsar/pull/16345
### Motivation
There are several logs messages, printed during the loading of a topic that
are quite redundant in the information they provide.
eg:
```
2022-07-01T20:58:25,229-0700 [pulsar-io-4-20] INFO
org.apache.pulsar.broker.service.ServerCnx - [/127.0.0.1:65427] Subscribing on
topic persistent://public/default/my-topic-49642 / sub
2022-07-01T20:58:44,797-0700 [broker-topic-workers-OrderedExecutor-1-0] INFO
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - Opening managed ledger
public/default/persistent/my-topic-49642
2022-07-01T20:58:45,481-0700 [bookkeeper-ml-scheduler-OrderedScheduler-2-0]
INFO org.apache.bookkeeper.mledger.impl.MetaStoreImpl - Creating
'/managed-ledgers/public/default/persistent/my-topic-49642'
2022-07-01T20:58:46,165-0700 [main-EventThread] INFO
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl -
[public/default/persistent/my-topic-49642] Creating ledger, metadata:
{component=[109, 97, 110, 97, 103, 101, 100, 45, 108, 101, 100, 103, 101, 114],
pulsar/managed-ledger=[112, 117, 98, 108, 105, 99, 47, 100, 101, 102, 97, 117,
108, 116, 47, 112, 101, 114, 115, 105, 115, 116, 101, 110, 116, 47, 109, 121,
45, 116, 111, 112, 105, 99, 45, 52, 57, 54, 52, 50], application=[112, 117,
108, 115, 97, 114]} - metadata ops timeout : 60 seconds
2022-07-01T20:58:49,495-0700 [BookKeeperClientWorker-OrderedExecutor-6-0]
INFO org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl -
[public/default/persistent/my-topic-49642] Created ledger 96543
2022-07-01T20:58:52,682-0700 [bookkeeper-ml-scheduler-OrderedScheduler-2-0]
INFO org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl -
[public/default/persistent/my-topic-49642] Successfully initialize managed
ledger
2022-07-01T20:58:52,682-0700 [bookkeeper-ml-scheduler-OrderedScheduler-2-0]
INFO org.apache.pulsar.broker.service.persistent.PersistentTopic -
[persistent://public/default/my-topic-49642] There are no replicated
subscriptions on the topic
2022-07-01T20:58:53,837-0700 [broker-topic-workers-OrderedExecutor-2-0] INFO
org.apache.pulsar.broker.service.AbstractTopic - Disabling publish throttling
for persistent://public/default/my-topic-49642
2022-07-01T20:58:53,837-0700 [broker-topic-workers-OrderedExecutor-2-0] INFO
org.apache.pulsar.broker.service.BrokerService - Created topic
persistent://public/default/my-topic-49642 - dedup is disabled
2022-07-01T20:58:53,837-0700 [broker-topic-workers-OrderedExecutor-2-0] INFO
org.apache.bookkeeper.mledger.impl.ManagedCursorImpl -
[public/default/persistent/my-topic-49642] Cursor sub recovered to position
96543:-1
2022-07-01T20:58:53,837-0700 [broker-topic-workers-OrderedExecutor-2-0] INFO
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl -
[public/default/persistent/my-topic-49642] Creating ledger, metadata:
{component=[109, 97, 110, 97, 103, 101, 100, 45, 108, 101, 100, 103, 101, 114],
pulsar/managed-ledger=[112, 117, 98, 108, 105, 99, 47, 100, 101, 102, 97, 117,
108, 116, 47, 112, 101, 114, 115, 105, 115, 116, 101, 110, 116, 47, 109, 121,
45, 116, 111, 112, 105, 99, 45, 52, 57, 54, 52, 50], pulsar/cursor=[115, 117,
98], application=[112, 117, 108, 115, 97, 114]} - metadata ops timeout : 60
seconds
2022-07-01T20:58:54,692-0700 [BookKeeperClientWorker-OrderedExecutor-2-0]
INFO org.apache.bookkeeper.mledger.impl.MetaStoreImpl -
[public/default/persistent/my-topic-49642] [sub] Updating cursor info
ledgerId=100045 mark-delete=96543:-1
2022-07-01T20:58:54,730-0700 [bookkeeper-ml-scheduler-OrderedScheduler-2-0]
INFO org.apache.bookkeeper.mledger.impl.ManagedCursorImpl -
[public/default/persistent/my-topic-49642] Updated cursor sub with ledger id
100045 md-position=96543:-1 rd-position=96543:0
2022-07-01T20:58:54,730-0700 [bookkeeper-ml-scheduler-OrderedScheduler-2-0]
INFO org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl -
[public/default/persistent/my-topic-49642] Opened new cursor:
ManagedCursorImpl{ledger=public/default/persistent/my-topic-49642, name=sub,
ackPos=96543:-1, readPos=96543:0}
2022-07-01T20:58:54,730-0700 [bookkeeper-ml-scheduler-OrderedScheduler-2-0]
INFO org.apache.bookkeeper.mledger.impl.ManagedCursorImpl -
[public/default/persistent/my-topic-49642-sub] Rewind from 96543:0 to 96543:0
2022-07-01T20:58:54,730-0700 [bookkeeper-ml-scheduler-OrderedScheduler-2-0]
INFO org.apache.pulsar.broker.service.persistent.PersistentTopic -
[persistent://public/default/my-topic-49642] There are no replicated
subscriptions on the topic
2022-07-01T20:58:54,730-0700 [bookkeeper-ml-scheduler-OrderedScheduler-2-0]
INFO org.apache.pulsar.broker.service.persistent.PersistentTopic -
[persistent://public/default/my-topic-49642][sub] Created new subscription for
49641
2022-07-01T20:58:54,730-0700 [bookkeeper-ml-scheduler-OrderedScheduler-2-0]
INFO org.apache.pulsar.broker.service.ServerCnx - [/127.0.0.1:65427] Created
subscription on topic persistent://public/default/my-topic-49642 / sub
```
One example is that on ledger creation, we're printing the ledger metadata,
which contains the topic name (that we already know) and it gets all converted
into `byte[]` so it's completely useless in the logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
