Jason918 commented on code in PR #16336:
URL: https://github.com/apache/pulsar/pull/16336#discussion_r912590535
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java:
##########
@@ -831,6 +831,9 @@ protected boolean
enqueueMessageAndCheckBatchReceive(Message<T> message) {
protected abstract void updateAutoScaleReceiverQueueHint();
protected boolean hasEnoughMessagesForBatchReceive() {
+ if (batchReceivePolicy.getTimeoutMs() <= 0) {
Review Comment:
It seems like a break change if user set this to 0, then `batchReceive()`
would return `Messages` with empty message immediately when there is no message
to consume.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
