codelipenghui commented on code in PR #16355:
URL: https://github.com/apache/pulsar/pull/16355#discussion_r912599441
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -2036,29 +2036,31 @@ private void
internalExpireMessagesForAllSubscriptionsForNonPartitionedTopic(Asy
});
}
- protected void internalResetCursor(AsyncResponse asyncResponse, String
subName, long timestamp,
+ protected CompletableFuture<Void> internalResetCursorAsync(String subName,
long timestamp,
boolean authoritative) {
+ CompletableFuture<Void> future;
if (topicName.isGlobal()) {
- try {
- validateGlobalNamespaceOwnership(namespaceName);
- } catch (Exception e) {
- log.warn("[{}][{}] Failed to reset cursor on subscription {}
to time {}: {}",
- clientAppId(), topicName,
- subName, timestamp, e.getMessage());
Review Comment:
Please don't missed the warning logs in the new change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
