shibd commented on code in PR #16279:
URL: https://github.com/apache/pulsar/pull/16279#discussion_r912790688


##########
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java:
##########
@@ -350,7 +351,8 @@ private StateStoreProvider getStateStoreProvider() throws 
Exception {
         }
     }
 
-    private void handleResult(Record srcRecord, JavaExecutionResult result) 
throws Exception {
+    @VisibleForTesting
+    protected void handleResult(Record srcRecord, JavaExecutionResult result) 
throws Exception {

Review Comment:
   This may not be great, but this test is important. It is also a way of 
compromise.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to