andrasbeni opened a new pull request, #16377:
URL: https://github.com/apache/pulsar/pull/16377
###Motivation
The admin client uses GET requests frequently. Most of these code places
share
a simple InvocationCallback that completes a CompletableFuture with the
response.
By moving all this into a common place, the code will be cleaner, and GET
requests
will look more like other requests.
###Modifications
Move the functionality implemented in InvocationCallbacks to a common place.
Hide creation of CompletableFuture to be consistent with other HTTP method
implementations (e.g. asyncPutRequest).
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework without any test coverage.
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
Need to update docs?
- [X] `doc-not-needed`
This is pure refactoring, no behavior is changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
