Technoboy- commented on code in PR #16313:
URL: https://github.com/apache/pulsar/pull/16313#discussion_r913843025
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java:
##########
@@ -736,14 +736,20 @@ public BundlesData getBundlesData(@PathParam("property")
String property, @PathP
@ApiResponse(code = 412, message = "Namespace is already unloaded
or Namespace has bundles activated")})
public void unloadNamespace(@Suspended final AsyncResponse asyncResponse,
@PathParam("property") String property,
@PathParam("cluster") String cluster, @PathParam("namespace")
String namespace) {
- try {
- validateNamespaceName(property, cluster, namespace);
- internalUnloadNamespace(asyncResponse);
- } catch (WebApplicationException wae) {
- asyncResponse.resume(wae);
- } catch (Exception e) {
- asyncResponse.resume(new RestException(e));
- }
+ validateNamespaceName(property, cluster, namespace);
Review Comment:
yes, right. However, for better code style and behavior, I still take your
opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
