nicoloboschi commented on code in PR #16396:
URL: https://github.com/apache/pulsar/pull/16396#discussion_r914565762
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v3/Transactions.java:
##########
@@ -345,7 +345,7 @@ public void scaleTransactionCoordinators(@Suspended final
AsyncResponse asyncRes
}
@GET
-
@Path("/pendingAckStats/{tenant}/{namespace}/{topic}/{subName}/{ledgerId}/{entryId}")
+
@Path("/positionStatsInPendingAck/{tenant}/{namespace}/{topic}/{subName}/{ledgerId}/{entryId}")
Review Comment:
can you confirm this endpoint is not released yet so it's not a real
breaking change?
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTransactions.java:
##########
@@ -196,6 +196,29 @@ void run() throws Exception {
}
}
+ @Parameters(commandDescription = "Get the position stats in transaction
pending ack")
+ private class GetPositionStatsInPendingAck extends CliCommand {
+ @Parameter(names = {"-t", "--topic"}, description = "the topic name",
required = true)
+ private String topic;
+
+ @Parameter(names = {"-s", "--sub-name"}, description = "the
subscription name", required = true)
+ private String subName;
+
+ @Parameter(names = {"-l", "--ledgerId"}, description = "the ledger ID
of the position", required = true)
Review Comment:
```suggestion
@Parameter(names = {"-l", "--ledger-id"}, description = "Ledger ID
of the position", required = true)
```
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTransactions.java:
##########
@@ -196,6 +196,29 @@ void run() throws Exception {
}
}
+ @Parameters(commandDescription = "Get the position stats in transaction
pending ack")
+ private class GetPositionStatsInPendingAck extends CliCommand {
+ @Parameter(names = {"-t", "--topic"}, description = "the topic name",
required = true)
+ private String topic;
+
+ @Parameter(names = {"-s", "--sub-name"}, description = "the
subscription name", required = true)
+ private String subName;
+
+ @Parameter(names = {"-l", "--ledgerId"}, description = "the ledger ID
of the position", required = true)
+ private Long ledgerId;
+
+ @Parameter(names = {"-e", "--entryId"}, description = "the entry ID of
the position", required = true)
+ private Long entryId;
+
+ @Parameter(names = {"-b", "--bacthIndex"}, description = "the
bacthIndex of the position")
Review Comment:
```suggestion
@Parameter(names = {"-b", "--batch-index"}, description = "Batch
index of the position")
```
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTransactions.java:
##########
@@ -196,6 +196,29 @@ void run() throws Exception {
}
}
+ @Parameters(commandDescription = "Get the position stats in transaction
pending ack")
+ private class GetPositionStatsInPendingAck extends CliCommand {
+ @Parameter(names = {"-t", "--topic"}, description = "the topic name",
required = true)
Review Comment:
Please capitalize the descriptions
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTransactions.java:
##########
@@ -196,6 +196,29 @@ void run() throws Exception {
}
}
+ @Parameters(commandDescription = "Get the position stats in transaction
pending ack")
+ private class GetPositionStatsInPendingAck extends CliCommand {
+ @Parameter(names = {"-t", "--topic"}, description = "the topic name",
required = true)
+ private String topic;
+
+ @Parameter(names = {"-s", "--sub-name"}, description = "the
subscription name", required = true)
Review Comment:
```suggestion
@Parameter(names = {"-s", "--subscription-name"}, description =
"Subscription name", required = true)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
