Anonymitaet commented on code in PR #16410:
URL: https://github.com/apache/pulsar/pull/16410#discussion_r914630421
##########
site2/website/versioned_docs/version-2.10.1/reference-configuration.md:
##########
@@ -378,6 +378,16 @@ brokerServiceCompactionThresholdInBytes|If the estimated
backlog size is greater
| strictBookieAffinityEnabled | Enable or disable the strict bookie isolation
strategy. If enabled, <br /> - `bookie-ensemble` first tries to choose bookies
that belong to a namespace's affinity group. If the number of bookies is not
enough, then the rest bookies are chosen. <br /> - If namespace has no affinity
group, `bookie-ensemble` only chooses bookies that belong to no region. If the
number of bookies is not enough, `BKNotEnoughBookiesException` is thrown.|
false |
|narExtractionDirectory | The extraction directory of the nar package. <br
/>Available for Protocol Handler, Additional Servlets, Entry Filter,
Offloaders, Broker Interceptor. | System.getProperty("java.io.tmpdir") |
+#### Configuration Override For Clients Internal to Broker
Review Comment:
```suggestion
#### Configuration override for clients internal to broker
```
In general, use a lowercase style in text and use sentence-style
capitalization for headings.
https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.1oxiv9hq05mn
##########
site2/website/versioned_docs/version-2.10.1/reference-configuration.md:
##########
@@ -378,6 +378,16 @@ brokerServiceCompactionThresholdInBytes|If the estimated
backlog size is greater
| strictBookieAffinityEnabled | Enable or disable the strict bookie isolation
strategy. If enabled, <br /> - `bookie-ensemble` first tries to choose bookies
that belong to a namespace's affinity group. If the number of bookies is not
enough, then the rest bookies are chosen. <br /> - If namespace has no affinity
group, `bookie-ensemble` only chooses bookies that belong to no region. If the
number of bookies is not enough, `BKNotEnoughBookiesException` is thrown.|
false |
|narExtractionDirectory | The extraction directory of the nar package. <br
/>Available for Protocol Handler, Additional Servlets, Entry Filter,
Offloaders, Broker Interceptor. | System.getProperty("java.io.tmpdir") |
+#### Configuration Override For Clients Internal to Broker
+
+It's possible to configure some clients by using the appropriate prefix.
+
+|Prefix|Description|
+|---|---|
+|brokerClient_| Configure **all** the broker's Pulsar Clients and Pulsar Admin
Clients. These configurations are applied after hard coded configuration and
before the above brokerClient configurations named above.|
+|bookkeeper_| Configure the broker's bookkeeper clients used by managed
ledgers and the BookkeeperPackagesStorage bookkeeper client. Takes precedence
over most other configuration values.|
+
+Note: when running the function worker within the broker, these prefixed
configurations do not apply to any of those clients. You must instead configure
those clients using the `functions_worker.yml`.
Review Comment:
```suggestion
::: Note
When running the function worker within the broker, these prefixed
configurations do not apply to any of those clients. You must configure those
clients using the `functions_worker.yml` file.
:::
```
https://docs.google.com/document/d/12De2btkDHQVaqUlHjTqERmroMLKGhHdiC7rEttFTyqc/edit#bookmark=id.jis8plesauvo
##########
site2/website/versioned_docs/version-2.10.1/reference-configuration.md:
##########
@@ -378,6 +378,16 @@ brokerServiceCompactionThresholdInBytes|If the estimated
backlog size is greater
| strictBookieAffinityEnabled | Enable or disable the strict bookie isolation
strategy. If enabled, <br /> - `bookie-ensemble` first tries to choose bookies
that belong to a namespace's affinity group. If the number of bookies is not
enough, then the rest bookies are chosen. <br /> - If namespace has no affinity
group, `bookie-ensemble` only chooses bookies that belong to no region. If the
number of bookies is not enough, `BKNotEnoughBookiesException` is thrown.|
false |
|narExtractionDirectory | The extraction directory of the nar package. <br
/>Available for Protocol Handler, Additional Servlets, Entry Filter,
Offloaders, Broker Interceptor. | System.getProperty("java.io.tmpdir") |
+#### Configuration Override For Clients Internal to Broker
+
+It's possible to configure some clients by using the appropriate prefix.
+
+|Prefix|Description|
+|---|---|
+|brokerClient_| Configure **all** the broker's Pulsar Clients and Pulsar Admin
Clients. These configurations are applied after hard coded configuration and
before the above brokerClient configurations named above.|
+|bookkeeper_| Configure the broker's bookkeeper clients used by managed
ledgers and the BookkeeperPackagesStorage bookkeeper client. Takes precedence
over most other configuration values.|
Review Comment:
```suggestion
|bookkeeper_| Configure the broker's BookKeeper clients used by managed
ledgers and the BookkeeperPackagesStorage bookkeeper client. Takes precedence
over most other configuration values.|
```
##########
site2/website/versioned_docs/version-2.10.1/reference-configuration.md:
##########
@@ -378,6 +378,16 @@ brokerServiceCompactionThresholdInBytes|If the estimated
backlog size is greater
| strictBookieAffinityEnabled | Enable or disable the strict bookie isolation
strategy. If enabled, <br /> - `bookie-ensemble` first tries to choose bookies
that belong to a namespace's affinity group. If the number of bookies is not
enough, then the rest bookies are chosen. <br /> - If namespace has no affinity
group, `bookie-ensemble` only chooses bookies that belong to no region. If the
number of bookies is not enough, `BKNotEnoughBookiesException` is thrown.|
false |
|narExtractionDirectory | The extraction directory of the nar package. <br
/>Available for Protocol Handler, Additional Servlets, Entry Filter,
Offloaders, Broker Interceptor. | System.getProperty("java.io.tmpdir") |
+#### Configuration Override For Clients Internal to Broker
+
+It's possible to configure some clients by using the appropriate prefix.
+
+|Prefix|Description|
+|---|---|
+|brokerClient_| Configure **all** the broker's Pulsar Clients and Pulsar Admin
Clients. These configurations are applied after hard coded configuration and
before the above brokerClient configurations named above.|
Review Comment:
```suggestion
|brokerClient_| Configure **all** the broker's Pulsar Clients and Pulsar
Admin Clients. These configurations are applied after hard coded configuration
and before the above broker client configurations named above.|
```
do we need a space between them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
