marksilcox commented on code in PR #15558:
URL: https://github.com/apache/pulsar/pull/15558#discussion_r914840072
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java:
##########
@@ -181,22 +181,26 @@ private static ByteBuf generate0(PulsarService pulsar,
boolean includeTopicMetri
//when write out 200MB data, MAX_COMPONENTS = 64 needn't mem_copy.
see: CompositeByteBuf#consolidateIfNeeded()
ByteBuf buf =
UnpooledByteBufAllocator.DEFAULT.compositeDirectBuffer(MAX_COMPONENTS);
boolean exceptionHappens = false;
+ //Used in namespace/topic and transaction aggregators as share metric
names
Review Comment:
Some metric names used in `TransactionAggregator` and `TopicStats` are the
same - e.g. `pulsar_storage_ledger_write_latency_le_0_5` - I don't see anywhere
these are prefixed differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
