pgier commented on code in PR #800: URL: https://github.com/apache/pulsar-client-go/pull/800#discussion_r915371157
########## Dockerfile: ########## @@ -17,21 +17,19 @@ # under the License. # -ARG GO_VERSION=golang:1.15 -FROM apachepulsar/pulsar:2.8.2 as pulsar -FROM $GO_VERSION as go +ARG PULSAR_IMAGE=apachepulsar/pulsar:latest +ARG GOLANG_IMAGE=golang:latest Review Comment: The version is fixed in the Makefile, so CI builds would always use the version set there. I set these to default to latest so that they don't become out of date. I can add a comment to the Dockerfile saying that these versions should be set via the Makefile or CLI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
