Jason918 commented on code in PR #16420:
URL: https://github.com/apache/pulsar/pull/16420#discussion_r915527164


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -3569,6 +3570,10 @@ private ManagedLedgerInfo getManagedLedgerInfo() {
         return buildManagedLedgerInfo(ledgers);
     }
 
+    private ManagedLedgerInfo getManagedLedgerInfo(NavigableMap<Long, 
LedgerInfo> ledgersTmp) {
+        return buildManagedLedgerInfo(ledgersTmp);

Review Comment:
   The `ledgersTmp` can be avoided by extending `buildManagedLedgerInfo`. Just 
add the new LedgerInfo after line 3578.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to