mattisonchao commented on code in PR #16420:
URL: https://github.com/apache/pulsar/pull/16420#discussion_r915598218
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -1545,21 +1546,21 @@ public void operationFailed(MetaStoreException e) {
}
};
- updateLedgersListAfterRollover(cb);
+ updateLedgersListAfterRollover(cb,
getManagedLedgerInfo(ledgersTmp));
}
}
-
- private void updateLedgersListAfterRollover(MetaStoreCallback<Void>
callback) {
+ private void updateLedgersListAfterRollover(MetaStoreCallback<Void>
callback, ManagedLedgerInfo mlInfo) {
if (!metadataMutex.tryLock()) {
// Defer update for later
- scheduledExecutor.schedule(() ->
updateLedgersListAfterRollover(callback), 100, TimeUnit.MILLISECONDS);
+ scheduledExecutor.schedule(() ->
updateLedgersListAfterRollover(callback, mlInfo),
Review Comment:
@lordcheng10
Yes, I also don't think it's a big problem, but maybe we can leave this
comment here. Perhaps someone can find some things that will be affected by
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
