Technoboy- commented on code in PR #16473:
URL: https://github.com/apache/pulsar/pull/16473#discussion_r917196729
##########
testmocks/src/main/java/org/apache/zookeeper/MockZooKeeper.java:
##########
@@ -532,6 +540,10 @@ public void getChildren(final String path, final Watcher
watcher, final Children
if (watcher != null) {
watchers.put(path, watcher);
}
+ } catch (Throwable ex) {
+ log.error("get children : {} error", path, ex);
+ cb.processResult(KeeperException.Code.SYSTEMERROR.intValue(),
path, ctx, null);
+ return;
Review Comment:
Better to move line 551 to `try` block and delete `return 546`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
