tisonkun commented on code in PR #15478:
URL: https://github.com/apache/pulsar/pull/15478#discussion_r917236963


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java:
##########
@@ -81,4 +81,12 @@ public static String removeIdentifierFromMetadataURL(String 
metadataURL) {
         }
         return metadataURL;
     }
+
+    public static boolean isBasedOnZookeeper(String metadataURL) {
+        if (!metadataURL.contains("://")) {

Review Comment:
   @merlimat it seems that metadata url doesn't contains `//` part?
   
   From the codebase a metadata url to zk is `zk:127.0.0.1:2181` and a metadata 
url to memory is `memory:local`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to