pgier commented on code in PR #798:
URL: https://github.com/apache/pulsar-client-go/pull/798#discussion_r917316822
##########
pulsar/table_view_impl.go:
##########
@@ -242,17 +242,20 @@ func (tv *TableViewImpl) Close() {
}
func (tv *TableViewImpl) handleMessage(msg Message) {
- tv.dataMu.Lock()
- defer tv.dataMu.Unlock()
+ if msg.Key() != "" {
Review Comment:
Minor suggestion to just return if the key is empty instead of nesting in
the if.
```suggestion
if msg.Key() == "" {
return
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
