merlimat commented on a change in pull request #3904: [go schema] support go
schema for pulsar-client-go
URL: https://github.com/apache/pulsar/pull/3904#discussion_r277129084
##########
File path: pulsar-client-go/pulsar/c_message.go
##########
@@ -97,8 +98,8 @@ func buildMessage(message ProducerMessage)
*C.pulsar_message_t {
////////////// Message
-func newMessageWrapper(ptr *C.pulsar_message_t) Message {
- msg := &message{ptr: ptr}
+func newMessageWrapper(schema Schema, ptr *C.pulsar_message_t) Message {
Review comment:
Interfaces are always passed by ref. Go syntax is a bit confusing since you
need to know that it's indeed an interface and not a struct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
