codelipenghui commented on code in PR #16507:
URL: https://github.com/apache/pulsar/pull/16507#discussion_r917472081
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java:
##########
@@ -1325,11 +1325,21 @@ public void
setMaxConsumersPerTopic(@PathParam("property") String property, @Pat
@ApiOperation(value = "Get maxConsumersPerSubscription config on a
namespace.")
@ApiResponses(value = {@ApiResponse(code = 403, message = "Don't have
admin permission"),
@ApiResponse(code = 404, message = "Namespace does not exist")})
- public Integer getMaxConsumersPerSubscription(@PathParam("property")
String property,
- @PathParam("cluster") String
cluster,
- @PathParam("namespace") String
namespace) {
+ public void getMaxConsumersPerSubscription(
+ @Suspended final AsyncResponse asyncResponse,
+ @PathParam("property") String property,
+ @PathParam("cluster") String cluster,
+ @PathParam("namespace") String namespace) {
validateNamespaceName(property, cluster, namespace);
- return internalGetMaxConsumersPerSubscription();
Review Comment:
Looks like we can remove `internalGetMaxConsumersPerSubscription`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
