[GitHub] [pulsar] HQebupt commented on a diff in pull request #16573: [fix][broker]fix the zero value as denominator cause ArithmeticException when selectBroker use LeastResourceUsageWithWeight

[GitBox]

HQebupt commented on code in PR #16573:
URL: https://github.com/apache/pulsar/pull/16573#discussion_r920005355


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/LeastResourceUsageWithWeight.java:
##########
@@ -125,6 +125,11 @@ private double 
updateAndGetMaxResourceUsageWithWeight(String broker, BrokerData
     @Override
     public Optional<String> selectBroker(Set<String> candidates, BundleData 
bundleToAssign, LoadData loadData,

Review Comment:
   <img width="1071" alt="image" 
src="https://user-images.githubusercontent.com/4970972/178730655-e86f38a7-ad30-4e5e-a5fc-71cb974d51b8.png";>
   There is a check here. Restore the list of brokers to the full set if 
brokerCandidateCache is empty.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org