eolivelli commented on code in PR #16545: URL: https://github.com/apache/pulsar/pull/16545#discussion_r920847730
########## conf/broker.conf: ########## @@ -232,6 +232,12 @@ subscriptionKeySharedUseConsistentHashing=true # The higher the number, the more equal the assignment of keys to consumers subscriptionKeySharedConsistentHashingReplicaPoints=100 +# Maximum time in ms for a Analise backlog operation to complete +subscriptionBacklogScanMaxTimeMs=120000 + +# Maximum number of entries to be read within a Analise backlog operation +subscriptionBacklogScanMaxTimeMs=10000 Review Comment: thanks ########## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpScan.java: ########## @@ -0,0 +1,124 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.bookkeeper.mledger.impl; + +import com.google.common.base.Predicate; +import java.util.List; +import java.util.Optional; +import java.util.concurrent.atomic.AtomicLong; +import lombok.extern.slf4j.Slf4j; +import org.apache.bookkeeper.mledger.AsyncCallbacks.ReadEntryCallback; +import org.apache.bookkeeper.mledger.AsyncCallbacks.ScanCallback; +import org.apache.bookkeeper.mledger.Entry; +import org.apache.bookkeeper.mledger.ManagedLedgerException; +import org.apache.bookkeeper.mledger.Position; +import org.apache.bookkeeper.mledger.ScanOutcome; +import org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl.PositionBound; + +@Slf4j +class OpScan implements ReadEntryCallback { + private final ManagedCursorImpl cursor; + private final ManagedLedgerImpl ledger; + private final PositionImpl startPosition; + private final ScanCallback callback; + private final Predicate<Entry> condition; + private final Object ctx; + private final AtomicLong remainingEntries = new AtomicLong(); + private final long timeOutMs; + private final long startTime = System.currentTimeMillis(); + + PositionImpl searchPosition; + Position lastMatchedPosition = null; + + public OpScan(ManagedCursorImpl cursor, PositionImpl startPosition, Predicate<Entry> condition, + ScanCallback callback, Object ctx, long maxEntries, long timeOutMs) { + this.cursor = cursor; + this.ledger = cursor.ledger; + this.startPosition = startPosition; + this.callback = callback; + this.condition = condition; + this.ctx = ctx; + this.searchPosition = startPosition; + this.remainingEntries.set(maxEntries); + this.timeOutMs = timeOutMs; + } + + + @Override + public void readEntryComplete(Entry entry, Object ctx) { + remainingEntries.decrementAndGet(); + final Position position = entry.getPosition(); + lastMatchedPosition = position; + // filter out the entry if it has been already deleted + // filterReadEntries will call entry.release if the entry is filtered out + List<Entry> entries = this.cursor.filterReadEntries(List.of(entry)); + if (!entries.isEmpty()) { + boolean exit = false; + try { + if (!condition.apply(entry)) { + exit = true; + } + entry.release(); + } catch (Throwable err) { + log.error("[{}] user exception", cursor, err); Review Comment: I moved it to a finally block but not here ########## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpScan.java: ########## @@ -0,0 +1,125 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.bookkeeper.mledger.impl; + +import com.google.common.base.Predicate; +import java.util.List; +import java.util.Optional; +import java.util.concurrent.atomic.AtomicLong; +import lombok.extern.slf4j.Slf4j; +import org.apache.bookkeeper.mledger.AsyncCallbacks.ReadEntryCallback; +import org.apache.bookkeeper.mledger.AsyncCallbacks.ScanCallback; +import org.apache.bookkeeper.mledger.Entry; +import org.apache.bookkeeper.mledger.ManagedLedgerException; +import org.apache.bookkeeper.mledger.Position; +import org.apache.bookkeeper.mledger.ScanOutcome; +import org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl.PositionBound; + +@Slf4j +class OpScan implements ReadEntryCallback { + private final ManagedCursorImpl cursor; + private final ManagedLedgerImpl ledger; + private final PositionImpl startPosition; + private final ScanCallback callback; + private final Predicate<Entry> condition; + private final Object ctx; + private final AtomicLong remainingEntries = new AtomicLong(); + private final long timeOutMs; + private final long startTime = System.currentTimeMillis(); + + PositionImpl searchPosition; + Position lastMatchedPosition = null; + + public OpScan(ManagedCursorImpl cursor, PositionImpl startPosition, Predicate<Entry> condition, + ScanCallback callback, Object ctx, long maxEntries, long timeOutMs) { + this.cursor = cursor; + this.ledger = cursor.ledger; + this.startPosition = startPosition; + this.callback = callback; + this.condition = condition; + this.ctx = ctx; + this.searchPosition = startPosition; + this.remainingEntries.set(maxEntries); + this.timeOutMs = timeOutMs; + } + + + @Override + public void readEntryComplete(Entry entry, Object ctx) { + remainingEntries.decrementAndGet(); + final Position position = entry.getPosition(); + lastMatchedPosition = position; + // filter out the entry if it has been already deleted + // filterReadEntries will call entry.release if the entry is filtered out + List<Entry> entries = this.cursor.filterReadEntries(List.of(entry)); + if (!entries.isEmpty()) { + boolean exit = false; + try { + if (!condition.apply(entry)) { + exit = true; + } + entry.release(); + } catch (Throwable err) { + log.error("[{}] user exception", cursor, err); + callback.scanFailed(ManagedLedgerException.getManagedLedgerException(err), + Optional.ofNullable(searchPosition), OpScan.this.ctx); + return; + } + if (exit) { + // user code requested to stop our scan + callback.scanComplete(lastMatchedPosition, ScanOutcome.USER_INTERRUPTED, OpScan.this.ctx); + return; + } + } + searchPosition = ledger.getPositionAfterN((PositionImpl) position, 1, PositionBound.startExcluded); + if (log.isDebugEnabled()) { + log.debug("readEntryComplete {} at {} next is {}", entry, position, searchPosition); + } + + if (searchPosition.compareTo((PositionImpl) position) == 0) { + // we have reached the end of the ledger, as we are not doing progress + callback.scanComplete(lastMatchedPosition, ScanOutcome.COMPLETED, OpScan.this.ctx); + return; + } + find(); + } + + @Override + public void readEntryFailed(ManagedLedgerException exception, Object ctx) { + callback.scanFailed(exception, Optional.ofNullable(searchPosition), OpScan.this.ctx); + } + + public void find() { + if (remainingEntries.get() <= 0) { + log.warn("[{}] Scan abort after reading too many entries", OpScan.this.cursor); + callback.scanComplete(lastMatchedPosition, ScanOutcome.ABORTED, OpScan.this.ctx); + return; + } + if (System.currentTimeMillis() - startTime > timeOutMs) { + log.warn("[{}] Scan abort after hitting the deadline", OpScan.this.cursor); + callback.scanComplete(lastMatchedPosition, ScanOutcome.ABORTED, OpScan.this.ctx); + return; + } + if (cursor != null ? cursor.hasMoreEntries(searchPosition) : ledger.hasMoreEntries(searchPosition)) { Review Comment: good point. I started from another Operation that worked also without the cursor. In this case there is no need for this null check. I am adding the null check in the constructor ########## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpScan.java: ########## @@ -0,0 +1,125 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.bookkeeper.mledger.impl; + +import com.google.common.base.Predicate; +import java.util.List; +import java.util.Optional; +import java.util.concurrent.atomic.AtomicLong; +import lombok.extern.slf4j.Slf4j; +import org.apache.bookkeeper.mledger.AsyncCallbacks.ReadEntryCallback; +import org.apache.bookkeeper.mledger.AsyncCallbacks.ScanCallback; +import org.apache.bookkeeper.mledger.Entry; +import org.apache.bookkeeper.mledger.ManagedLedgerException; +import org.apache.bookkeeper.mledger.Position; +import org.apache.bookkeeper.mledger.ScanOutcome; +import org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl.PositionBound; + +@Slf4j +class OpScan implements ReadEntryCallback { + private final ManagedCursorImpl cursor; + private final ManagedLedgerImpl ledger; + private final PositionImpl startPosition; + private final ScanCallback callback; + private final Predicate<Entry> condition; + private final Object ctx; + private final AtomicLong remainingEntries = new AtomicLong(); + private final long timeOutMs; + private final long startTime = System.currentTimeMillis(); + + PositionImpl searchPosition; + Position lastMatchedPosition = null; + + public OpScan(ManagedCursorImpl cursor, PositionImpl startPosition, Predicate<Entry> condition, + ScanCallback callback, Object ctx, long maxEntries, long timeOutMs) { + this.cursor = cursor; + this.ledger = cursor.ledger; + this.startPosition = startPosition; + this.callback = callback; + this.condition = condition; + this.ctx = ctx; + this.searchPosition = startPosition; + this.remainingEntries.set(maxEntries); + this.timeOutMs = timeOutMs; + } + + + @Override + public void readEntryComplete(Entry entry, Object ctx) { + remainingEntries.decrementAndGet(); + final Position position = entry.getPosition(); + lastMatchedPosition = position; + // filter out the entry if it has been already deleted + // filterReadEntries will call entry.release if the entry is filtered out + List<Entry> entries = this.cursor.filterReadEntries(List.of(entry)); + if (!entries.isEmpty()) { + boolean exit = false; + try { + if (!condition.apply(entry)) { + exit = true; + } + entry.release(); Review Comment: good point -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
