tisonkun commented on code in PR #16332:
URL: https://github.com/apache/pulsar/pull/16332#discussion_r922115354
##########
bin/pulsar-shell:
##########
@@ -18,7 +18,19 @@
# under the License.
#
-BINDIR=$(dirname "$0")
+# need this for relative symlinks
+PRG="$0"
+while [ -h "$PRG" ] ; do
+ ls=`ls -ld "$PRG"`
+ link=`expr "$ls" : '.*-> \(.*\)$'`
+ if expr "$link" : '/.*' > /dev/null; then
+ PRG="$link"
+ else
+ PRG="`dirname "$PRG"`/$link"
+ fi
+done
Review Comment:
@nicoloboschi Thanks for your explanation. I get this point.
When do you use pulsar-shell as a symbol link? From this patch we copy the
script itself into the tarball:
```
<file>
<outputDirectory>bin</outputDirectory>
<source>${basedir}/../../bin/pulsar-shell</source>
<fileMode>755</fileMode>
</file>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
