Demogorgon314 commented on code in PR #16409:
URL: https://github.com/apache/pulsar/pull/16409#discussion_r922925609
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2085,6 +2085,13 @@ public class ServiceConfiguration implements
PulsarConfiguration {
)
private double
loadBalancerMsgThroughputMultiplierDifferenceShedderThreshold = 4;
+ @FieldContext(
+ dynamic = true,
+ category = CATEGORY_LOAD_BALANCER,
+ doc = "For each uniform balanced unload, the maximum number of
bundles that can be unloaded."
+ )
+ private int maxUnloadBundleNumPerShedding = 2;
Review Comment:
> The purpose of adding this configuration is to control the number of
bundles unloaded at one time, and prevent too many bundles unloaded at one
time, resulting in cluster instability.
Ok, you can add this purpose to the `Motivation ` part. Also, I believe we
still need to add the unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
