freeznet commented on code in PR #16472:
URL: https://github.com/apache/pulsar/pull/16472#discussion_r922933137
##########
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java:
##########
@@ -855,13 +854,8 @@ protected List<String> getExecutorCommand() {
}
private List<String> getDownloadCommand(Function.FunctionDetails
functionDetails, String userCodeFilePath) {
- if (Arrays.stream(PackageType.values()).anyMatch(type ->
Review Comment:
Agreed with @zymap, the real issue here is the `packageUrl` is not been set
properly, but not the "unused" issue. The correct way is to make the
`packageUrl` set when the user creates functions with package URLs from the
package management service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
