nahguam opened a new pull request, #16646:
URL: https://github.com/apache/pulsar/pull/16646
### Motivation
In the admin client, each GET request handler implements its own
`InvocationCallback` which it implements anonymously at the callsites.
Jersey requires a concrete implementation to get around type erasure
since it uses reflection to identify the generic type. However, there
are few variants of the `InvocationCallback` implementations in the
admin client and most are identical - handling the response/exception
into a `CompletableFuture`.
### Modifications
Refactor the admin client GET handlers to be more DRY by providing a
`GetCallback` abstract implementation of `InvocationCallback` that
handles the response/exception into a `CompletableFuture` result.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
