[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #16408: [fix][broker] Support loadBalancerSheddingIntervalMinutes dynamic configuration

Mon, 18 Jul 2022 06:00:28 -0700 


lordcheng10 commented on code in PR #16408:
URL: https://github.com/apache/pulsar/pull/16408#discussion_r923345415


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1032,9 +1030,10 @@ protected void startLeaderElectionService() {
                             if (loadResourceQuotaTask != null) {
                                 loadResourceQuotaTask.cancel(false);
                             }
-                            loadSheddingTask = 
loadManagerExecutor.scheduleAtFixedRate(
-                                    new LoadSheddingTask(loadManager),
-                                    loadSheddingInterval, 
loadSheddingInterval, TimeUnit.MILLISECONDS);
+                            loadSheddingTask = loadManagerExecutor.schedule(

Review Comment:
   like this:
   <img width="936" alt="image" 
src="https://user-images.githubusercontent.com/19296967/179516593-ea1925ae-852a-4f72-99fd-e0b821c578dd.png";>
   



##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1032,9 +1030,10 @@ protected void startLeaderElectionService() {
                             if (loadResourceQuotaTask != null) {
                                 loadResourceQuotaTask.cancel(false);
                             }
-                            loadSheddingTask = 
loadManagerExecutor.scheduleAtFixedRate(
-                                    new LoadSheddingTask(loadManager),
-                                    loadSheddingInterval, 
loadSheddingInterval, TimeUnit.MILLISECONDS);
+                            loadSheddingTask = loadManagerExecutor.schedule(

Review Comment:
   fixed, like this:
   <img width="936" alt="image" 
src="https://user-images.githubusercontent.com/19296967/179516593-ea1925ae-852a-4f72-99fd-e0b821c578dd.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to