eolivelli commented on code in PR #15474:
URL: https://github.com/apache/pulsar/pull/15474#discussion_r925198545
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1760,7 +1760,9 @@ private void checkConsumedLedgers() {
if (t instanceof PersistentTopic) {
Optional.ofNullable(((PersistentTopic)
t).getManagedLedger()).ifPresent(
managedLedger -> {
-
managedLedger.trimConsumedLedgersInBackground(Futures.NULL_PROMISE);
+ if
(!managedLedger.maybeUpdateCursorBeforeTrimmingConsumedLedger()){
Review Comment:
can we add a comment here please, to explain why we are skipping the
execution ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
