jiangpengcheng commented on code in PR #16697:
URL: https://github.com/apache/pulsar/pull/16697#discussion_r925357042
##########
pulsar-functions/instance/src/main/python/python_instance_main.py:
##########
@@ -123,21 +123,21 @@ def main():
# run pip install to target folder deps folder
zpfile = zipfile.ZipFile(str(args.py), 'r')
zpfile.extractall(os.path.dirname(str(args.py)))
- basename = os.path.splitext(str(args.py))[0]
+ basename = os.path.basename(os.path.splitext(str(args.py))[0])
Review Comment:
if using original code, when specify `--py` with relative path like
`py/exclamation.zip`, the `deps_dir` will become `py/py/exclamation/deps` while
the correct one is `py/exclamation/deps`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
