poorbarcode commented on code in PR #16685:
URL: https://github.com/apache/pulsar/pull/16685#discussion_r926554988
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -343,6 +346,8 @@ public BrokerService(PulsarService pulsar, EventLoopGroup
eventLoopGroup) throws
this.backlogQuotaManager = new BacklogQuotaManager(pulsar);
this.backlogQuotaChecker = Executors
.newSingleThreadScheduledExecutor(new
DefaultThreadFactory("pulsar-backlog-quota-checker"));
+ this.transactionLogBufferedWriteAsyncFlushTrigger = Executors
+ .newSingleThreadScheduledExecutor(new
DefaultThreadFactory("pulsar-backlog-quota-checker"));
Review Comment:
I will fix it in the next PR
##########
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionLogImpl.java:
##########
@@ -66,13 +74,24 @@ public class MLTransactionLogImpl implements TransactionLog
{
private final TopicName topicName;
+ private TxnLogBufferedWriter<TransactionMetadataEntry> bufferedWriter;
+
+ private final ScheduledExecutorService scheduledExecutorService;
+
+ private final TxnLogBufferedWriterConfig txnLogBufferedWriterConfig;
+
public MLTransactionLogImpl(TransactionCoordinatorID tcID,
ManagedLedgerFactory managedLedgerFactory,
- ManagedLedgerConfig managedLedgerConfig) {
+ ManagedLedgerConfig managedLedgerConfig,
+ TxnLogBufferedWriterConfig
txnLogBufferedWriterConfig,
+ ScheduledExecutorService
scheduledExecutorService) {
this.topicName = getMLTransactionLogName(tcID);
this.tcId = tcID.getId();
this.managedLedgerFactory = managedLedgerFactory;
this.managedLedgerConfig = managedLedgerConfig;
+ this.scheduledExecutorService = scheduledExecutorService;
+ this.txnLogBufferedWriterConfig = txnLogBufferedWriterConfig;
+ this.managedLedgerConfig.setDeletionAtBatchIndexLevelEnabled(true);
Review Comment:
Already fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
