codelipenghui commented on code in PR #16714:
URL: https://github.com/apache/pulsar/pull/16714#discussion_r926611270
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/namespace/NamespaceServiceTest.java:
##########
@@ -602,8 +602,8 @@ public void testSplitLargestBundle() throws Exception {
*/
@Test
public void testSplitBundleWithHighestThroughput() throws Exception {
-
conf.setLoadManagerClassName(ModularLoadManagerImpl.class.getName());
+ conf.setLoadBalancerEnabled(false);
Review Comment:
Hmmm, it's a little confusing. The test is related to the load manager but
need to disable the load balancer in the test.
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/namespace/NamespaceServiceTest.java:
##########
@@ -602,8 +602,8 @@ public void testSplitLargestBundle() throws Exception {
*/
@Test
public void testSplitBundleWithHighestThroughput() throws Exception {
-
conf.setLoadManagerClassName(ModularLoadManagerImpl.class.getName());
+ conf.setLoadBalancerEnabled(false);
Review Comment:
I think without this change, the flaky test can also be fixed? Since we will
not return null for method `getBundleWithHighestThroughput`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
