momo-jun commented on code in PR #16722:
URL: https://github.com/apache/pulsar/pull/16722#discussion_r927333759


##########
site2/docs/reference-metrics.md:
##########
@@ -435,6 +435,15 @@ All the subscription metrics are labelled with the 
following labels:
 | pulsar_subscription_msg_rate_out | Gauge | The total message dispatch rate 
for a subscription (message per second). |
 | pulsar_subscription_msg_throughput_out | Gauge | The total message dispatch 
throughput for a subscription (byte per second). |
 | pulsar_subscription_msg_ack_rate | Gauge | The total message acknowledgment 
rate for a subscription (message per second). |
+| pulsar_subscription_last_expire_timestamp | Gauge | The subscription last 
message expire execution timestamp. |
+| pulsar_subscription_last_acked_timestamp | Gauge | The subscription last 
acked message timestamp. |
+| pulsar_subscription_last_consumed_flow_timestamp | Gauge | The subscription 
last received consume flow command timestamp. |
+| pulsar_subscription_last_consumed_timestamp | Gauge | The subscription last 
consume message timestamp. |
+| pulsar_subscription_last_mark_delete_advanced_timestamp | Gauge | The 
subscription last MarkDelete position advanced timestamp. |

Review Comment:
   ```suggestion
   | pulsar_subscription_last_mark_delete_advanced_timestamp | Gauge | The 
advanced timestamp of the last MarkDelete position on the subscription. |
   ```
   Is this what you meant? Not sure whether the concept of the advanced 
timestamp has been clearly conveyed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to