TakaHiR07 opened a new issue, #16732:
URL: https://github.com/apache/pulsar/issues/16732

   **Is your enhancement request related to a problem? Please describe.**
   https://github.com/apache/pulsar/pull/16219, this pr fix the bug if 
bookkeeperClientExposeStatsToPrometheus is true. But after enable bookie client 
metrics, I found that it would generate too much prometheus metrics, which 
obviously drop pulsar performance. 
   
   As shown in the screenshot,pulsar_managedLedger_client metrics have 19473 
lines, among them 18512 lines are per_channel_bookie_client metrics.
   
   
![wecom-temp-066c41c403bfa60b0eafe9fe61c1aea9](https://user-images.githubusercontent.com/13505225/180383247-f3668957-0e8a-4cf9-9ec5-c65b88936feb.png)
   
![wecom-temp-8b3a0da34f97a82dce6b3560a714e3ce](https://user-images.githubusercontent.com/13505225/180383395-e154b43e-3727-4374-a598-e7dff4b4f6c0.png)
   
   
   Actually, some metrics such as 
pulsar_managedLedger_client_BookKeeperClientWorker, 
pulsar_managedLedger_client_bookkeeper_client_ADD_ENTRY are useful for us and 
need to be opened. But the amount of per_channel_bookie_client metrics are 
usually not useful. 
   
   
   
   **Describe the solution you'd like**
   Therefore, I think we should add a configuration to limit the 
per_channel_bookie_client metrics when we enable 
bookkeeperClientExposeStatsToPrometheus. 
   
   And I notice that in bookkeeper, a conf  "limitStatsLogging" can limit those 
metrics, which 
    was proposed in this pr, https://github.com/apache/bookkeeper/pull/1888. 
   
   We should also add this conf in pulsar.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to