sijie commented on a change in pull request #4108: [pulsar-clients]Save name, type, properties for KeyValueSchema URL: https://github.com/apache/pulsar/pull/4108#discussion_r277834027
########## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchema.java ########## @@ -22,6 +22,7 @@ import java.nio.ByteBuffer; +import com.google.gson.Gson; Review comment: @cckellogg we don't need to use the shaded dependencies here. we use the normal dependencies. the gson dependency will be shaded when we build `pulsar-client` jar. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
