merlimat commented on a change in pull request #4079: PIP-34 Key_Shared
subscription core implementation.
URL: https://github.com/apache/pulsar/pull/4079#discussion_r277903141
##########
File path: pulsar-common/src/main/proto/PulsarApi.proto
##########
@@ -234,6 +236,7 @@ message CommandSubscribe {
Exclusive = 0;
Shared = 1;
Failover = 2;
+ Key_Shared = 3;
Review comment:
This change is not breaking at the protocol level and there's anyway no
check in the code when a consumer tries to subscribe if the broker supports the
feature or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
