rdhabalia commented on a change in pull request #4066: Allow to configure the 
managed ledger cache eviction frequency
URL: https://github.com/apache/pulsar/pull/4066#discussion_r277906213
 
 

 ##########
 File path: 
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
 ##########
 @@ -912,67 +904,6 @@ public long getTotalSize() {
         return TOTAL_SIZE_UPDATER.get(this);
     }
 
-    @Override
-    public void checkBackloggedCursors() {
 
 Review comment:
   I would still keep this optimization where broker will not cache the entry 
at all if cursor is not caught up because there is no point to add entries for 
backlogged cursor because they are anyway not going to use it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to