shibd commented on code in PR #16760:
URL: https://github.com/apache/pulsar/pull/16760#discussion_r928269376
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java:
##########
@@ -2169,10 +2210,20 @@ public void removeOffloadPolicies(@PathParam("tenant")
String tenant, @PathParam
@ApiResponses(value = {
@ApiResponse(code = 403, message = "Don't have admin permission"),
@ApiResponse(code = 404, message = "Namespace does not exist")})
- public OffloadPoliciesImpl getOffloadPolicies(@PathParam("tenant") String
tenant,
- @PathParam("namespace")
String namespace) {
+ public void getOffloadPolicies(
+ @Suspended final AsyncResponse asyncResponse,
+ @PathParam("tenant") String tenant,
+ @PathParam("namespace") String namespace) {
validateNamespaceName(tenant, namespace);
- return internalGetOffloadPolicies();
+ validateNamespacePolicyOperationAsync(namespaceName,
PolicyName.OFFLOAD, PolicyOperation.READ)
+ .thenCompose(__ -> getNamespacePoliciesAsync(namespaceName))
+ .thenAccept(policies ->
asyncResponse.resume(policies.offload_policies))
+ .exceptionally(ex -> {
+ log.error("[{}] Failed to get offload configuration on a
namespace {}", clientAppId(),
Review Comment:
```suggestion
log.error("[{}] Failed to get offload policies on a
namespace {}", clientAppId(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
