nodece commented on code in PR #16700:
URL: https://github.com/apache/pulsar/pull/16700#discussion_r929493156
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java:
##########
@@ -79,6 +80,12 @@ public static class RootParams {
description = "Enable TLS common name verification")
Boolean tlsEnableHostnameVerification;
+ @Parameter(names = {"--tls-provider"}, description = "Set up TLS
provider. "
+ + "When TLS authentication with CACert is used, the valid
value is either OPENSSL or JDK. "
+ + "When TLS authentication with KeyStore is used, available
options can be SunJSSE, Conscrypt "
+ + "and so on.")
+ String tlsProvider;
Review Comment:
> Will it throw an exception if user providers lowercase like `openssl`?
Yes. It will throw no Enum.
> Or we can use Enum instead ?
Here are multiple values: OPENSSL, JDK, SunJSSE and so on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
