Nicklee007 commented on code in PR #16799:
URL: https://github.com/apache/pulsar/pull/16799#discussion_r930566303


##########
pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarSinkE2ETest.java:
##########
@@ -189,6 +189,11 @@ public void testPulsarSinkDLQ() throws Exception {
             remainingMessagesToReceive.add(messageBody);
         }
 
+        // Wait all msg show in dlqTopic.
+        Awaitility.await().untilAsserted(()-> {
+            
assertEquals(admin.topics().getLastMessageId(dlqTopic).toString(),"10:1:-1:8");

Review Comment:
   > Can we guarantee that the message-id is the same for every testing? There 
is an exception in this
   
   seems that you are right



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to