Jason918 opened a new pull request, #16808:
URL: https://github.com/apache/pulsar/pull/16808

   cherry-pick #14545 to branch 2.7
   
   
   ### Motivation
   When the user config the offloader, as the ledger close, it will trigger the 
ledger to offload. If there are many ledgers that need to offload, but the 
topic has been unloaded, the offloader will continue to offload. Because the 
offloader uses the shared executor pool in ManagedLedgerFactoryImpl and when 
the managed ledger closes, it doesn't cancel the tasks.
   
   ```
   15:29:59.180 [pulsar-web-41-3] INFO  
org.apache.pulsar.broker.admin.impl.PersistentTopicsBase - [null] Unloading 
topic persistent://public/default/UpdateNodeCharts
   15:29:59.201 [pulsar-web-41-3] INFO  
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - 
[public/default/persistent/UpdateNodeCharts] Closing managed ledger
   15:29:59.216 [main-EventThread] INFO  
org.apache.bookkeeper.mledger.impl.MetaStoreImpl - 
[public/default/persistent/UpdateNodeCharts] [cloud-nodes-service] Updating 
cursor info ledgerId=-1 mark-delete=789182:82011
   15:29:59.219 [bookkeeper-ml-scheduler-OrderedScheduler-4-0] INFO  
org.apache.bookkeeper.mledger.impl.ManagedCursorImpl - 
[public/default/persistent/UpdateNodeCharts][cloud-nodes-service] Closed cursor 
at md-position=789182:82011
   15:29:59.221 [bookkeeper-ml-scheduler-OrderedScheduler-4-0] INFO  
org.apache.pulsar.broker.service.persistent.PersistentTopic - 
[persistent://public/default/UpdateNodeCharts] Topic closed
   15:29:59.221 [bookkeeper-ml-scheduler-OrderedScheduler-4-0] INFO  
org.apache.pulsar.broker.admin.impl.PersistentTopicsBase - [null] Successfully 
unloaded topic persistent://public/default/UpdateNodeCharts
   15:31:05.432 [offloader-OrderedScheduler-1-0] INFO  
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - 
[public/default/persistent/UpdateNodeCharts] Preparing metadata to offload 
ledger 422142 with uuid 030267e2-a2f9-40a3-848b-482f9b007c00
   15:31:05.432 [offloader-OrderedScheduler-1-0] INFO  
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - 
[public/default/persistent/UpdateNodeCharts] Found previous offload attempt for 
ledger 422142, uuid 030267e2-a2f9-40a3-848b-482f9b007c00, cleaning up
   15:31:05.432 [offloader-OrderedScheduler-1-0] INFO  
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - 
[public/default/persistent/UpdateNodeCharts] Cleanup offload for ledgerId 
422142 uuid 3725b3c1-1dbc-481f-a1dd-8aaffb75e603 because of the reason Previous 
failed offload.
   ```
   
   ### Modifications
   
   - When do `offloadLoop`, check state first. if `Close`, nothing to do. 
   
   ### Documentation
     
   - [x] `no-need-doc` 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to