poorbarcode commented on PR #16758: URL: https://github.com/apache/pulsar/pull/16758#issuecomment-1197620543
> I don't see where the `TxnLogBufferedWriterMetricsDefinition.java`'s `labelNames` and `labelValues` has been set, except in the tests. - `TxnLogBufferedWriterMetricsDefinition` will create by `MlTransactionLogImpl` and `MlPendingAckStore` in next PR. - In tests `TxnLogBufferedWriterTest`, `labelNames` and `labelValues` is set by Initializes block which is at top of the class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
