sijie commented on a change in pull request #4113: Update library versions
URL: https://github.com/apache/pulsar/pull/4113#discussion_r278229108
##########
File path: pom.xml
##########
@@ -185,8 +187,8 @@ flexible messaging model and an intuitive client
API.</description>
<mysql-jdbc.version>8.0.11</mysql-jdbc.version>
<elasticsearch.version>6.3.2</elasticsearch.version>
<presto.version>0.206</presto.version>
- <flink.version>1.6.0</flink.version>
- <scala.binary.version>2.11</scala.binary.version>
+ <flink.version>1.8.0</flink.version>
+ <scala.binary.version>2.12</scala.binary.version>
Review comment:
any particular reason that you are changing scala version from 2.11 to 2.12?
Changing scala version can potentially impacting the down stream application
who is using flink. I would prefer leaving it as 2.11 for now unless there is a
strong reason call out for changing this to 2.12.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
