merlimat commented on a change in pull request #4122: Improve tests for
ReaderImpl and ManagedLedgerImpl
URL: https://github.com/apache/pulsar/pull/4122#discussion_r278239065
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/client/api/TopicReaderTest.java
##########
@@ -554,7 +563,7 @@ public void
testReaderIsAbleToSeekWithTimeOnBeginningOfTopic() throws Exception
producer.close();
}
- @Test
+ @Test(timeOut = 5000)
Review comment:
> I think 5 secs should be long enough to wait for this test. Do you want to
leave it with default value or this explicit 5 secs?
Yes, on most machines it will take far less. On Apache Jenkins we've seen
that things can get much slower and start causing spurious timeouts. I'd leave
it at the default since it will not slowdown the tests. Timeout is just to
prevent a test getting stuck to stop the job.
> Overall time taken by TopicReaderTests improves by half (from 30 secs to
15 secs in my machine) not so much but is something :)
That's nice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
